Quantcast
Channel: Issues for XML sitemap
Viewing all articles
Browse latest Browse all 1238

Typo in XmlSiteMapTestBase.php

$
0
0

There is a typo in this function:

  protected function verbose($verbose_message, $message = 'Verbose message') {
    if ($id = parent::verbose($verbose_message)) {
      $url = file_create_url($this->originalFileDirectory . '/simpletest/verbose/' . get_class($this) . '-' . $id . '.html');
      $message_url = Url::fromUri($url, array('attributes' => array('target' => '_blank')));
      $this->error($this->l($message, $message_url)), 'User notice');
    }
  }

I believe it should be $this->error($this->l($message, $message_url), 'User notice');

I don't know how to run tests locally so I'm just noting this for now. I can make a proper patch once I figure out how to test my change.

There is an @TODO on this code that says it can be removed when #800426: Allow configurable verbose message summary besides 'Verbose message' is fixed. That is a D7 issue that has an almost 5 year old patch so isn't looking likely to be fixed but is the problem still an issue in D8?


Viewing all articles
Browse latest Browse all 1238

Trending Articles